Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@sourcery-ai
Copy link

@sourcery-ai sourcery-ai bot commented Dec 1, 2021

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from MattFisher December 1, 2021 02:13
def get_auth(whichAuth, token, password):
auth = (token, password)
return auth
return token, password
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function get_auth refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Dec 1, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.64%.

Quality metrics Before After Change
Complexity 5.04 ⭐ 5.14 ⭐ 0.10 👎
Method Length 50.83 ⭐ 50.33 ⭐ -0.50 👍
Working memory 6.92 🙂 7.00 🙂 0.08 👎
Quality 66.43% 🙂 65.79% 🙂 -0.64% 👎
Other metrics Before After Change
Lines 82 81 -1
Changed files Quality Before Quality After Quality Change
demo.py 66.43% 🙂 65.79% 🙂 -0.64% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
demo.py main 7 ⭐ 216 ⛔ 8 🙂 54.64% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.