Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Conversation

@williamblevins
Copy link
Contributor

@williamblevins williamblevins commented Mar 23, 2021

Change Description

Fix for nodeos parameter tests not working for custom build directory locations.

I left the code which gets the VERSION_HASH and the BOOST_VERSION as those variables don't seem to be available from within the cmake context. I think they are private?

Subsumes #10151

Change Type

Select ONE:

  • Documentation
  • Stability bug fix
  • Other
  • Other - special case

Testing Changes

Select ANY that apply:

  • New Tests
  • Existing Tests
  • Test Framework
  • CI System
  • Other

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@williamblevins williamblevins changed the base branch from master to release/2.0.x March 23, 2021 16:26
@williamblevins williamblevins marked this pull request as ready for review March 23, 2021 17:47
@williamblevins williamblevins requested a review from kj4ezj March 23, 2021 17:47
@williamblevins williamblevins merged commit 934d9d6 into release/2.0.x Mar 25, 2021
@williamblevins williamblevins deleted the wlb/ctest_generalization_for_parameter_tests_2.0.x branch March 25, 2021 20:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.