#41 Fixed enum definition parser repeating last value twice#46
Merged
Adhara3 merged 2 commits intoEFeru:mainEFeru/DbcParser:mainfrom Sep 26, 2023
Merged
#41 Fixed enum definition parser repeating last value twice#46Adhara3 merged 2 commits intoEFeru:mainEFeru/DbcParser:mainfrom
Adhara3 merged 2 commits intoEFeru:mainEFeru/DbcParser:mainfrom
Conversation
Updated tests to check for correct parsing of enum definitions
Fixed the regex for parsing enum definitions, which got broken by a change related to EFeru#41.
f87b757 to
31bf706
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regex to parse enum definition values got broken by a change related to #41. It had two nested capture groups which led to the last value beeing repeated twice. Fixed the regex and updated the test code to check for the correct values.