Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

check if exception was set before clearing it #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippedistributive merged 2 commits into from
Jul 17, 2024
Merged

check if exception was set before clearing it #384

philippedistributive merged 2 commits into from
Jul 17, 2024

Conversation

@philippedistributive
Copy link
Collaborator

@philippedistributive philippedistributive commented Jul 16, 2024

minor improvement

zollqir
zollqir reviewed Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@zollqir zollqir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyErr_Clear has no effect if there is not an error set, so I think its fine to leave it as-is. See here

@philippedistributive philippedistributive merged commit fb900e8 into main Jul 17, 2024
@philippedistributive philippedistributive deleted the philippe/382-followup branch July 17, 2024 15:10
@philippedistributive
Copy link
Collaborator Author

philippedistributive commented Aug 1, 2024

We said it looks better for program logic to check first if it is the case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zollqir zollqir zollqir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philippedistributive @zollqir
Morty Proxy This is a proxified and sanitized view of the page, visit original site.