You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR unifies the style of access to a value's type's name, replacing type(x).__name__ with x.__class__.__name__ (since the latter has been used more often)
Also moves a type guard at disnake/ext/tasks/init.py#L125-L127 higher up, so it can fail quicker.
Checklist
If code changes were made, then they have been tested
I have updated the documentation to reflect the changes
I have formatted the code properly by running uv run nox -s lint
I have type-checked the code by running uv run nox -s pyright
This PR fixes an issue
This PR adds something new (e.g. new method or parameters)
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)
There's a risk to this as __class__ can be overridden by user code, and the majority of these are used in instances where the instance check failed and a type could be an arbitrary type.
I'm not sure unification of these is necessary in one big go, but we should probably standardize on a specific type for future code.
The PR could go the other way and replace .__class__ with type().
Just wanted to standardize it as a prelude to standardizing exception messages that I have a branch for
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies the style of access to a value's type's name, replacing
type(x).__name__withx.__class__.__name__(since the latter has been used more often)Also moves a type guard at disnake/ext/tasks/init.py#L125-L127 higher up, so it can fail quicker.
Checklist
uv run nox -s lintuv run nox -s pyright