Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore: Use prek instead of pre-commit#1391

Open
tpoliaw wants to merge 1 commit intomainDiamondLightSource/blueapi:mainfrom
prek-conversionDiamondLightSource/blueapi:prek-conversionCopy head branch name to clipboard
Open

chore: Use prek instead of pre-commit#1391
tpoliaw wants to merge 1 commit intomainDiamondLightSource/blueapi:mainfrom
prek-conversionDiamondLightSource/blueapi:prek-conversionCopy head branch name to clipboard

Conversation

@tpoliaw
Copy link
Contributor

@tpoliaw tpoliaw commented Feb 16, 2026

Trial run ahead of converting python-copier-template

@tpoliaw tpoliaw requested a review from a team as a code owner February 16, 2026 10:42
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.03%. Comparing base (fe35430) to head (9d6d9fc).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          43       43           
  Lines        2779     2779           
=======================================
  Hits         2641     2641           
  Misses        138      138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tpoliaw tpoliaw mentioned this pull request Feb 16, 2026
Open
@tpoliaw tpoliaw changed the title Use prek instead of pre-commit chore: Use prek instead of pre-commit Feb 16, 2026
@ZohebShaikh
Copy link
Contributor

ZohebShaikh commented Feb 16, 2026

One of the reasoning mentioned in using per was that it is faster,
Can there be some profiling on how much faster it is ?

@tpoliaw
Copy link
Contributor Author

tpoliaw commented Feb 16, 2026

Their own benchmarks
Linked third party benchmarks

Running a similar test in blueapi

❯ hyperfine --prepare 'prek clean && pre-commit clean' 'prek install-hooks' 'pre-commit install-hooks'                                                                                                                                11:57:23
Benchmark 1: prek install-hooks
  Time (mean ± σ):      2.121 s ±  0.279 s    [User: 4.148 s, System: 0.554 s]
  Range (min … max):    1.895 s …  2.834 s    10 runs

Benchmark 2: pre-commit install-hooks
  Time (mean ± σ):     30.325 s ±  1.180 s    [User: 39.897 s, System: 4.673 s]
  Range (min … max):   28.766 s … 33.107 s    10 runs

Summary
  'prek install-hooks' ran
   14.30 ± 1.96 times faster than 'pre-commit install-hooks'

@tpoliaw
Copy link
Contributor Author

tpoliaw commented Feb 16, 2026

Actually running the checks is much closer as most of the hooks are the same

❯ hyperfine --warmup 10 'prek run --all-files' 'pre-commit run --all-files'                                                                                                                                                           12:11:01
Benchmark 1: prek run --all-files
  Time (mean ± σ):     261.4 ms ±   4.5 ms    [User: 210.7 ms, System: 95.1 ms]
  Range (min … max):   256.6 ms … 272.2 ms    10 runs

Benchmark 2: pre-commit run --all-files
  Time (mean ± σ):     815.3 ms ± 120.0 ms    [User: 1418.7 ms, System: 217.3 ms]
  Range (min … max):   749.5 ms … 1138.0 ms    10 runs

Summary
  'prek run --all-files' ran
    3.12 ± 0.46 times faster than 'pre-commit run --all-files'

abbiemery
abbiemery approved these changes Feb 17, 2026
View reviewed changes
Copy link
Contributor

@abbiemery abbiemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work for me. I do think we should have a page in the reference docs that has the commands you now need to run to use the dev tooling. For the most part this would be a link to the copier template docs. I did remember there being a link but I didn't find it when I looked (albeit quickly) earlier.

In the case of this early adoption having them written in such a page would be helpful since this differs from other repos at diamond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abbiemery abbiemery abbiemery approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tpoliaw @ZohebShaikh @abbiemery
Morty Proxy This is a proxified and sanitized view of the page, visit original site.