include ExplicitConstructorAttribute's targets to constructor&method #1982
Merged
mgravell merged 2 commits intoDapperLib:mainDapperLib/Dapper:mainfrom Oct 22, 2023
DeagleGross:dmkorolev/explicitconstructor-tomethodDeagleGross/Dapper:dmkorolev/explicitconstructor-tomethodCopy head branch name to clipboard
Merged
include ExplicitConstructorAttribute's targets to constructor&method #1982mgravell merged 2 commits intoDapperLib:mainDapperLib/Dapper:mainfrom DeagleGross:dmkorolev/explicitconstructor-tomethodDeagleGross/Dapper:dmkorolev/explicitconstructor-tomethodCopy head branch name to clipboard
mgravell merged 2 commits intoDapperLib:mainDapperLib/Dapper:mainfrom
DeagleGross:dmkorolev/explicitconstructor-tomethodDeagleGross/Dapper:dmkorolev/explicitconstructor-tomethodCopy head branch name to clipboard
Conversation
mgravell
reviewed
Oct 14, 2023
mgravell
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Dapper.AOT we are implementing a support for factory method construction of instances. As proposed by @mgravell - we can use existing
Dapper.ExplicitConstructorAttributefor that - but we need to expand the attribute targets model.PR link: Non-trivial instance construction with factory methods #59;
Proposition link: keep the name and change the allowable targets (C)