consolidate and improve internal rest infrastructure #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use pre-computed count properties instead of Enumerable.Count()
…/consolidate-rest
Naamloos
approved these changes
Sep 20, 2023
Directory.Packages.props
Outdated
| <PackageVersion Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0"/> | ||
| <PackageVersion Include="Microsoft.Extensions.DependencyModel" Version="7.0.0"/> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.1"/> | ||
| <PackageVersion Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="all"/> |
There was a problem hiding this comment.
re-add SourceLink, required for our docs bot to function iirc
themonarchoftime
approved these changes
Sep 25, 2023
…dsharpplus into fix/consolidate-rest
OoLunar
pushed a commit
that referenced
this pull request
Oct 3, 2024
* rearrange rest request objects * the ratelimit buckets are no longer bloatware * the arrival of the -gods- new ratelimiter * de-bloat the bucket even further and get rid of S.R.IS inclusion * kill dead code and reformat SessionBucket * clean up the rest client * update BadRequestException throwing * throw UnauthorizedExceptions correctly * use the regex generator * finish up the exceptions * administer file scoped namespaces upon DiscordApiClient.cs * sort endpoints alphabetically * format and update the DiscordApiClient prelude * make QueryUriBuilder fit for the purpose * fix another merge conflict * dotnet format * target-typed new and use pre-computed count properties instead of Enumerable.Count() * missed another merge conflict * update DiscordApiClient.cs, guild region, to the new system * fix this url * clean up stickers * Update first method * i knew i missed smth * nullability on a payload * Region Channel reworked * Region Threads reworked * Region Member reworked * Region Roles reworked * Region Prune, GuildVarious, Invite, Connections, Voice, Webhooks reworked * Region Reactions, Emoji, Application Commands, Misc and the rest (pun intended) reworked * nullability annotate the API client * fix build errors in corelib * fix a build error in the channel description tool * fix build errors for DSP.Rest * dispose of JsonDocuments as required * re-add Microsoft.SourceLink.GitHub back into project * re-added sourcelink reference * use strings instead of uri in infra * Uris to strings and fix one outlier * fix routes * actually set the base uri * Use global Base_Uri * engineer the url manually * log uris correctly * erm * correct the query uri builder * fix another conflict --------- Co-authored-by: akiraveliara <akiraveliara@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewoks the whole rest client to be faster and slightly more accurate
Details
Future Notes
this PR does NOT update the rest client to match the current API specification yet, that work will have to be done in a later PR