Lint project using Swfitlint#79
Merged
liamnichols merged 5 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Aug 2, 2022
Merged
Lint project using Swfitlint#79liamnichols merged 5 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
liamnichols merged 5 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
Conversation
Contributor
Author
|
The last file change seems odd, unless the test needed to be updated elsewhere and wasn't caught then. |
liamnichols
approved these changes
Aug 2, 2022
Member
liamnichols
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for picking this up
Comment on lines
328
to
333
| return """ | ||
| \(access)init(from decoder: Decoder) throws { | ||
|
|
||
| struct Discriminator: Decodable { | ||
| let \(discriminator.propertyName): String | ||
| } |
Member
There was a problem hiding this comment.
This is what caused the change to generated code @LePips.
I don't think it's an issue since its just whitespace (better to strip it though) but its worth being mindful that the linter might mistakenly mess some other stuff up.
Member
|
I'll merge this now since there are minimal actual changes, we can discuss adding/adjusting rules later on 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial
swiftlint autocorrectbut with no CI. Config rules are up for discussion.