Tests - Automatic Path Finding and Remove Environment Variables#62
Tests - Automatic Path Finding and Remove Environment Variables#62liamnichols merged 4 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom LePips:automatic-path-finding-for-testsLePips/CreateAPI:automatic-path-finding-for-testsCopy head branch name to clipboard
Conversation
|
Is there a specific reason why an environment variable is set to generate versus a static bool? I think it would be more convenient if it was just a static bool for general development and then a |
liamnichols
left a comment
There was a problem hiding this comment.
Oh awesome! Thanks so much for picking this up 🙌
Is there a specific reason why an environment variable is set to generate versus a static bool? I think it would be more convenient if it was just a static bool for general development and then a
FORCE_GENERATE_SNAPSHOTenvironment variable would override that to force generation elsewhere.
Not that I'm aware of. I agree though, a static bool is easier to conditionally enable I think so happy to change it (same with the OPEN_DIFF var)
|
I'll be able to provide steps for testing after, or during, your README update PR as mentioned in your current PR #52. |
liamnichols
left a comment
There was a problem hiding this comment.
Looking great! Thanks for sorting the environment variables too 🙏
I think we should prefer private over fileprivate when at the top-level but other than that, everything seems great 👍
liamnichols
left a comment
There was a problem hiding this comment.
Awesome stuff! Thanks for doing this, it makes it so much easier to test locally 🙇
#filePathis the closest we can get in regards to "automatic file path finding".