Add Entities.include#5
Merged
kean merged 8 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Jan 21, 2022
imjn:add-include-featureCopy head branch name to clipboard
Merged
Add Entities.include#5kean merged 8 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom imjn:add-include-featureCopy head branch name to clipboard
kean merged 8 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
imjn:add-include-featureCopy head branch name to clipboard
Conversation
This reverts commit 6baafda.
Member
|
Looks great, thanks for the contribution. I also added a ticket to replace "skip" everywhere #6 as a reminder. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :)
What
While implementing this plugin into our project, I found that
Entities.skipis very hard to maintain.Therefore, I'd like to implement
includewhich works completely opposite way fromskip.Background
We are currently just replacing hard-coded entities with CreateAPI generated entities, but of course, it is difficult to replace hundreds of entities at once. Therefore, we plan to replace them gradually. In this context,
includeis much more useful thanskip.Changes
skiptoexcludeto provide a kind of consistency withinclude. If you have any other suggestions, please :)includeincludeandexcludehave value.