Fixed fileHeader option to fileHeaderComment#22
Merged
kean merged 2 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Feb 17, 2022
imjn:return-file-header-with-lint-and-importsimjn/CreateAPI:return-file-header-with-lint-and-importsCopy head branch name to clipboard
Merged
Fixed fileHeader option to fileHeaderComment#22kean merged 2 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom imjn:return-file-header-with-lint-and-importsimjn/CreateAPI:return-file-header-with-lint-and-importsCopy head branch name to clipboard
kean merged 2 commits intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
imjn:return-file-header-with-lint-and-importsimjn/CreateAPI:return-file-header-with-lint-and-importsCopy head branch name to clipboard
Conversation
Member
|
The initial intention was to allow you to override the entire header, but I guess it's not very practical. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY
Currently, if fileHeader is set,
swiftlintandimportlines are not generated.I believe the option should override only the file header comment, not the entire file header including
swiftlintandimports.