fix: Discriminator respects useSwiftyPropertyNames#216
Open
AndrewSB wants to merge 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
AndrewSB:andrew/discriminator-respect-property-nameAndrewSB/CreateAPI:andrew/discriminator-respect-property-nameCopy head branch name to clipboard
Open
fix: Discriminator respects useSwiftyPropertyNames#216AndrewSB wants to merge 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom AndrewSB:andrew/discriminator-respect-property-nameAndrewSB/CreateAPI:andrew/discriminator-respect-property-nameCopy head branch name to clipboard
AndrewSB wants to merge 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
AndrewSB:andrew/discriminator-respect-property-nameAndrewSB/CreateAPI:andrew/discriminator-respect-property-nameCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON parsing for discriminators fails when the discriminator's
propertyNamehas an_in it, and the default value ofswiftyPropertyNamesis truethis fix uses the
PropertyNameprocessing to respect the options passed into the generatorin practice, a
JSONDecoderwith.keyDecodingStrategy = .convertFromSnakeCaseset will fail to parsesome_kindsince it's looking forsomeKindinstead.this change will result in this being generated instead