Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Fix shouldGenerate check for entities.include option#20

Merged
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
ainame:fix-generator-for-entities-includeainame/CreateAPI:fix-generator-for-entities-includeCopy head branch name to clipboard
Feb 8, 2022
Merged

Fix shouldGenerate check for entities.include option#20
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
ainame:fix-generator-for-entities-includeainame/CreateAPI:fix-generator-for-entities-includeCopy head branch name to clipboard

Conversation

@ainame
Copy link
Contributor

@ainame ainame commented Feb 8, 2022

While testing the upstream changes, entities defined in entities.include were skipped. I noticed shouldGenerate for entities option doesn't look right. I suppose it should have checked options.entities.include instead of options.path.include in Generator+Schemas.swift.

You can test it with any configurations that have entities.include. I believe entities defined in entities.include should not be skipped.

entities:
  isGeneratingStructs: true
  # Wanted to try this option!
  isGeneratingMutableStructProperties: false

  include:
    User

@ainame ainame changed the title Fix shouldGenerate check for entities option Fix shouldGenerate check for entities.include option Feb 8, 2022
@kean kean merged commit dbaeb8a into CreateAPI:main Feb 8, 2022
@ainame ainame deleted the fix-generator-for-entities-include branch February 8, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.