Fix shouldGenerate check for entities.include option#20
Merged
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Feb 8, 2022
ainame:fix-generator-for-entities-includeainame/CreateAPI:fix-generator-for-entities-includeCopy head branch name to clipboard
Merged
Fix shouldGenerate check for entities.include option#20kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom ainame:fix-generator-for-entities-includeainame/CreateAPI:fix-generator-for-entities-includeCopy head branch name to clipboard
kean merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
ainame:fix-generator-for-entities-includeainame/CreateAPI:fix-generator-for-entities-includeCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the upstream changes, entities defined in
entities.includewere skipped. I noticedshouldGeneratefor entities option doesn't look right. I suppose it should have checkedoptions.entities.includeinstead ofoptions.path.includeinGenerator+Schemas.swift.You can test it with any configurations that have
entities.include. I believe entities defined inentities.includeshould not be skipped.