Update Get dependency to require 2.1.x or later#160
Merged
liamnichols merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom Oct 10, 2022
mgrider:mainCopy head branch name to clipboard
Merged
Update Get dependency to require 2.1.x or later#160liamnichols merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom mgrider:mainCopy head branch name to clipboard
liamnichols merged 1 commit intoCreateAPI:mainCreateAPI/CreateAPI:mainfrom
mgrider:mainCopy head branch name to clipboard
Conversation
Closed
liamnichols
approved these changes
Oct 10, 2022
Member
liamnichols
left a comment
There was a problem hiding this comment.
Thanks so much for picking this up @mgrider!
Changes look great to me. In terms of testing, I think that + the CI checks should be plenty as the 2.x version release was only a major release to fix up the API design of Request 👍
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only "real" changes here are in
PackageDeclaration.swiftandGenerator+Paths.swift. The other files are test results that have changed.I did also test this on a project I'm working on, but I don't feel like that's a great test really, as I'm not sure I'm using all the features of Get or a complex OpenAPI schema.