Improve error messages that are used when oneOf object decoding fails#159
Merged
liamnichols merged 2 commits intomainCreateAPI/CreateAPI:mainfrom Oct 5, 2022
ln/oneOf-enum-error-messagesCreateAPI/CreateAPI:ln/oneOf-enum-error-messagesCopy head branch name to clipboard
Merged
Improve error messages that are used when oneOf object decoding fails#159liamnichols merged 2 commits intomainCreateAPI/CreateAPI:mainfrom ln/oneOf-enum-error-messagesCreateAPI/CreateAPI:ln/oneOf-enum-error-messagesCopy head branch name to clipboard
oneOf object decoding fails#159liamnichols merged 2 commits intomainCreateAPI/CreateAPI:mainfrom
ln/oneOf-enum-error-messagesCreateAPI/CreateAPI:ln/oneOf-enum-error-messagesCopy head branch name to clipboard
Conversation
oneOf object decoding fails
imjn
approved these changes
Oct 5, 2022
Member
imjn
left a comment
There was a problem hiding this comment.
Amazing!!! Thank you very much.
Finally, it's time to adapt DTO and Path to search pages.
This will save me a lot of time 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
oneOftypes in some conditions #158When we faced the linked bug above, it was hard to figure out exactly what was going on at first. The only message that we saw was the following:
It would be nicer if the message logged could help us to understand what has gone on a little more so I have updated it so that it includes more details about the issue.
You can see the diff of the snapshots for an idea of how this looks.