Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Enable fixed width integers by default and update documentation#145

Merged
liamnichols merged 4 commits intomainCreateAPI/CreateAPI:mainfrom
ln/dataType-testsCreateAPI/CreateAPI:ln/dataType-testsCopy head branch name to clipboard
Aug 16, 2022
Merged

Enable fixed width integers by default and update documentation#145
liamnichols merged 4 commits intomainCreateAPI/CreateAPI:mainfrom
ln/dataType-testsCreateAPI/CreateAPI:ln/dataType-testsCopy head branch name to clipboard

Conversation

@liamnichols
Copy link
Member

@liamnichols liamnichols commented Aug 15, 2022

@liamnichols
Copy link
Member Author

I'm still on the fence as to wether we want this as the default behaviour or not 😅 Before merging I might double check some other generators to see how they handle fixed-width integers by default.

@LePips
Copy link
Contributor

LePips commented Aug 15, 2022

I ultimately think whatever is fine. I just have the thought that we should generate as closely to the schema as possible by default and then it's configurable to change that behavior.

@liamnichols
Copy link
Member Author

So SwagGen has a similar fixedWidthIntegers flag that is false by default, and openapi-generator uses fixed width integers by default so I'm going to stick with this change and change the default behaviour 👍

@liamnichols liamnichols marked this pull request as ready for review August 16, 2022 18:20
@liamnichols liamnichols self-assigned this Aug 16, 2022
@liamnichols liamnichols merged commit adb3b8d into main Aug 16, 2022
@liamnichols liamnichols deleted the ln/dataType-tests branch August 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.