Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Run path generation in parallel when specified#140

Merged
liamnichols merged 1 commit intomainCreateAPI/CreateAPI:mainfrom
ln/parallel-pathsCreateAPI/CreateAPI:ln/parallel-pathsCopy head branch name to clipboard
Aug 14, 2022
Merged

Run path generation in parallel when specified#140
liamnichols merged 1 commit intomainCreateAPI/CreateAPI:mainfrom
ln/parallel-pathsCreateAPI/CreateAPI:ln/parallel-pathsCopy head branch name to clipboard

Conversation

@liamnichols
Copy link
Member

@liamnichols liamnichols commented Aug 14, 2022

I noticed that the code to generate paths would only perform parallel generation when --verbose was specified. Something that I assume was done during debugging but committed by mistake?

It's inconsistent with the other implementation so I have instead set this value back to check arguments.isParallel instead. The result is that by default, the GitHub spec now generates a bit quicker:

Before

$ swift run create-api generate Tests/Support/Specs/github.yaml --config-option module=OctoKit --measure --clean
...
Generate paths completed (0.852 s)
Generating entities completed (0.402 s)
Write output files completed (0.170 s)
Generation completed (2.892 s)

After

$ swift run create-api generate Tests/Support/Specs/github.yaml --config-option module=OctoKit --measure --clean
...
Generate paths completed (0.280 s)
Generating entities completed (0.410 s)
Write output files completed (0.163 s)
Generation completed (2.293 s)

@liamnichols liamnichols self-assigned this Aug 14, 2022
@liamnichols liamnichols merged commit 6d8ae62 into main Aug 14, 2022
@liamnichols liamnichols deleted the ln/parallel-paths branch August 14, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@liamnichols liamnichols

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@liamnichols
Morty Proxy This is a proxified and sanitized view of the page, visit original site.