Automatically update AllPackages bundle when regenerating snapshots#123
Automatically update AllPackages bundle when regenerating snapshots#123liamnichols merged 4 commits intomainCreateAPI/CreateAPI:mainfrom ln/all-packages-manifest-generationCreateAPI/CreateAPI:ln/all-packages-manifest-generationCopy head branch name to clipboard
Conversation
|
Great stuff! With the inclusion of the |
I was thinking about it, but was slightly deterred because of the scenario where you might run just one test rather than all of them. But maybe there is a way to detect that.. I'll keep looking at this because after looking again at the code this morning, I think I want to refactor it some more as well 😄 |
…rite upon completion of tests
2a12e66 to
6e322dc
Compare
|
Took a much cleaner approach now by breaking things out into their own responsibilities. We now have |
When we recreate the generator snapshots, if we add a new package we usually have to manually update Tests/CreateAPITests/AllPackages/Package.swift so that CI will try and build the package when we create Pull Requests. This was a pain to keep on top of.
In this change, I update the tests so that they record all of the generated packages and upon completion of the tests, they update the Package.swift file.
It's a little rough and ready, but I didn't want to spend a lot of time refactoring this area although I think that we probably could do. Any suggestions for improvements are welcome.
cc @LePips