Heatmaps should not applying to lakes #2834
Conversation
I have attached corresponding screenshots and savegames to the PR and issue 👌 |
|
I suspect it would break if the lake was assigned a parcel number which is a perfectly valid thing for a map maker to do. |
| @@ -485,7 +485,7 @@ bool level_map::load_from_th_file(const uint8_t* pData, size_t iDataLength, | ||
|
|
||
| if (!(pData[5] & 1)) { | ||
| pNode->flags.passable = true; | ||
| if (!(pData[7] & 16)) { | ||
| if (!(pData[7] & 16) && pNode->iParcelId != 0) { |
There was a problem hiding this comment.
Albert also states in #1991 (comment) it ideally needs an afterload to handle this change. What that would look like I'm not sure... There's probably a method to request a refresh of map data from lua.
There was a problem hiding this comment.
Was thinking of Map:setCellFlags but generally this requires each tile to be given unless there's a way to efficiently pull all pond tiles from a map and then apply.
There was a problem hiding this comment.
Iterating over them and selection pond tiles is the best you can do here. Even in CPP that's what you need to do.
|
closed in preference to #2837 |
Fixes #1991
PR with changed presented by Albert #1991 (comment)
2834_Heatmaps_on_lakes_1.sav.zip
2834_Heatmaps_on_lakes_2.sav.zip
v0.68.0 :
this PR :