Windows 10/11 dark mode #2604
Windows 10/11 dark mode #2604
Conversation
|
I'm excited to see this PR. In the past, I tried to add dark mode but didn't finish. I would be happy to merge your PR, but I'd like to keep compatibility with older Windows versions. |
| DarkDialogInit(hDlg); | ||
| return FALSE; | ||
|
|
||
| case WM_CTLCOLORDLG: |
There was a problem hiding this comment.
This looks like a copy/paste added to several dialog classes.
It's better to move this processing into a separate function, e.g. CSetPgBase::ProcessCtlColors and call the function from here.
The signature might be
bool CSetPgApps::ProcessCtlColors(HWND hDlg, UINT messg, WPARAM wParam, LPARAM lParam, INT_PTR& lResult)
when ProcessCtlColors returns true, pageOpProc will return lResult. So we don't need to implement case's in pageOp.
| @@ -1,90 +1,16 @@ | ||
| ## About ConEmu |
There was a problem hiding this comment.
Please add changes into the original readme, instead of making a copy.
| <ConfigurationType>Application</ConfigurationType> | ||
| <UseDebugLibraries>false</UseDebugLibraries> | ||
| <CharacterSet>Unicode</CharacterSet> | ||
| <PlatformToolset>v141_xp</PlatformToolset> |
There was a problem hiding this comment.
Please keep PlatformToolset unchanged. if you don't have v141_xp installed, you may use v141 for your local tests. But please don't add this change to the PR.
In case you need you need some new Win11 API, you may add/call functions using DwmHelper.
| <EnableCOMDATFolding>true</EnableCOMDATFolding> | ||
| <OptimizeReferences>true</OptimizeReferences> | ||
| <AdditionalDependencies>comctl32.lib;shlwapi.lib;version.lib;gdiplus.lib;winmm.lib;netapi32.lib;%(AdditionalDependencies)</AdditionalDependencies> | ||
| <AdditionalDependencies>comctl32.lib;shlwapi.lib;version.lib;gdiplus.lib;winmm.lib;netapi32.lib;Dwmapi.lib;UxTheme.lib;%(AdditionalDependencies)</AdditionalDependencies> |
There was a problem hiding this comment.
No need to add this libs. They are loaded automatically on demand. Please remove to keep compatibility with older windows versions
| @@ -0,0 +1,93 @@ | ||
| // This file contains code from |
There was a problem hiding this comment.
Could you explain why do we need this?
|
@59de44955ebd Are you going to be revisiting this? |
Hi, I hacked Windows 10/11 dark mode support into ConEmu, it's not perfect yet, but maybe you want to check it out.