Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Changes in PR #48 break backward compat? #49

Copy link
Copy link
Closed
@nrocy

Description

@nrocy
Issue body actions

PR #48 replaced deprecated calls to parents() with ancestors() but this project package.json seems to allow for symfony/dom-crawler 4.4: ^4.4 | ^5.4 | ^6.0

The ancestors() function wasn't added to dom-crawler until 5.3.0-BETA-1 so this seems to be a backward-compat breaking change.

Happy to help assist fix this as it's breaking our tests, how would you prefer to resolve it?

Thanks!

/cc @TavoNiievez

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.