Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[6759] Add separate errors tab in HTML report (redirected to 'main') #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

sem-peters
Copy link

(copied from #6765)

Fix for #6759

I added a separate tab for errors. I also added an internal test that errors to test the HTML reporter itself. I can imagine this is undesirable, so please let me know if I have to remove it!

@SamMousa
Copy link
Collaborator

I did not even know / remember we had an HTML report, thanks for making me aware, something I'll be using soon for sure.

This PR is missing some minor things:

  1. Code style
  2. The failing test should not be part of our test suite, it's not actually testing the HTML reporter
  3. There should be a test testing the HTML reporter, it should be interacting with the pulblic functions of the reporter directly and confirming the final output.

Since we're currently not testing the HTMLReporter class I can't really put it all on you to fully test the class.
What I'd like you to test are the following functions:

  • testUseless
  • testError

You'll need to do something like this:

$reportHandle = tmpfile();
$output = ...
$reporter = new HtmlReporter(['html' => stream_get_meta_data($reportHandle)['uri']], $output);
// Test
$reporter->testUseless(...);


// Assert output
rewind($reportHandle);
$report = stream_get_contents($reportHandle);

// Assert that I see some pretty HTML error stuff.

@sem-peters
Copy link
Author

Thanks for the review, I'll get on it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.