Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 30, 2018. It is now read-only.

Added support for repository comments #13

Open
georgebrock wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

Added support for repository comments #13

georgebrock wants to merge 1 commit into from

Conversation

@georgebrock
Copy link

@georgebrock georgebrock commented Jul 18, 2012

In doing so I broke backward compatibility (by renaming the existing comments method on the Repo class to issue_comments) so you may not want to merge this in as-is.

@naktinis
Copy link
Contributor

naktinis commented Feb 12, 2013

You could rename it to repo_comments for example.

@georgebrock
Copy link
Author

georgebrock commented Feb 18, 2013

The method is on a Repo class: having Repo.comments return issue comments and Repo.repo_comments return repo comments seems very confusing to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@georgebrock @naktinis
Morty Proxy This is a proxified and sanitized view of the page, visit original site.