Remove direct calls to integer constructor of DiscreteElement#814
Merged
tpadioleau merged 2 commits intomainCExA-project/ddc:mainfrom Apr 7, 2025
discrete-element-cleaningCExA-project/ddc:discrete-element-cleaningCopy head branch name to clipboard
Merged
Remove direct calls to integer constructor of DiscreteElement#814tpadioleau merged 2 commits intomainCExA-project/ddc:mainfrom discrete-element-cleaningCExA-project/ddc:discrete-element-cleaningCopy head branch name to clipboard
tpadioleau merged 2 commits intomainCExA-project/ddc:mainfrom
discrete-element-cleaningCExA-project/ddc:discrete-element-cleaningCopy head branch name to clipboard
Conversation
bb8c5d0 to
dfb574d
Compare
dfb574d to
1b52e15
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (20)
- include/ddc/discrete_domain.hpp: Language not supported
- include/ddc/discrete_element.hpp: Language not supported
- include/ddc/discrete_vector.hpp: Language not supported
- include/ddc/experimental/single_discretization.hpp: Language not supported
- include/ddc/kernels/splines/bsplines_non_uniform.hpp: Language not supported
- include/ddc/kernels/splines/bsplines_uniform.hpp: Language not supported
- include/ddc/non_uniform_point_sampling.hpp: Language not supported
- include/ddc/periodic_sampling.hpp: Language not supported
- include/ddc/strided_discrete_domain.hpp: Language not supported
- include/ddc/trivial_space.hpp: Language not supported
- include/ddc/uniform_point_sampling.hpp: Language not supported
- tests/chunk.cpp: Language not supported
- tests/chunk_span.cpp: Language not supported
- tests/create_mirror.cpp: Language not supported
- tests/discrete_domain.cpp: Language not supported
- tests/fft/fft.cpp: Language not supported
- tests/for_each.cpp: Language not supported
- tests/parallel_deepcopy.cpp: Language not supported
- tests/parallel_fill.cpp: Language not supported
- tests/parallel_for_each.cpp: Language not supported
jbigot
previously approved these changes
Apr 7, 2025
tpadioleau
commented
Apr 7, 2025
Member
Author
tpadioleau
left a comment
There was a problem hiding this comment.
Thanks for the review.
jbigot
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Copilot reviewed 7 out of 27 changed files in this pull request and generated no comments.
Files not reviewed (20)
- include/ddc/discrete_domain.hpp: Language not supported
- include/ddc/discrete_element.hpp: Language not supported
- include/ddc/discrete_vector.hpp: Language not supported
- include/ddc/experimental/single_discretization.hpp: Language not supported
- include/ddc/kernels/splines/bsplines_non_uniform.hpp: Language not supported
- include/ddc/kernels/splines/bsplines_uniform.hpp: Language not supported
- include/ddc/non_uniform_point_sampling.hpp: Language not supported
- include/ddc/periodic_sampling.hpp: Language not supported
- include/ddc/strided_discrete_domain.hpp: Language not supported
- include/ddc/trivial_space.hpp: Language not supported
- include/ddc/uniform_point_sampling.hpp: Language not supported
- tests/chunk.cpp: Language not supported
- tests/chunk_span.cpp: Language not supported
- tests/create_mirror.cpp: Language not supported
- tests/discrete_domain.cpp: Language not supported
- tests/fft/fft.cpp: Language not supported
- tests/for_each.cpp: Language not supported
- tests/parallel_deepcopy.cpp: Language not supported
- tests/parallel_fill.cpp: Language not supported
- tests/parallel_for_each.cpp: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uidDiscreteElementconstructor with integerSome are remaining in the splines builder and evaluator. The
DiscreteElementtests also rely on it, not sure this is needed.