Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Oct 17, 2023

This is intended to re-organise the various user options and controls, to bring all user-facing controls into a cohesive "my-account" area. This includes the creation of new "my-account" profile controls, so we can target and seperate the editing of "my-account" from that of admin controls which are intended to manage accounts that are not the current user (mostly). Means we can provide a UX intended for the seperate use-cases.

Todo

  • Add new my-account profile form.
  • Ensure sidebar item highlighting works for all my-account items
  • Update "External Auth" fields to always show (not be auth type specific, maybe hidden by default though).
  • Have link from user profile to user admin profile form if permissions allow.
  • Have link to user public activity profile.
  • Update API token URLs and return user to correct location on save/cancel.
  • Ensure translations extracted to files
  • Provide user self-delete flow
  • Clean up & split-out (if needed) old preference test cases.
  • Clean up header profile dropdown menu.
  • Specifically cover non-admin profile email field disabling/message with testing.
  • Test across dark mode.
  • Test with different auth methods.
  • Re-test each action across all my-account and admin user management views.
  • Testing

Docs Updates

  • Advise of changes to URLs.
    • No /preferences URLs anymore.
    • API token URLs changed.
    • Old profile routes non-accessible without users-manage permission.

Notes

  • Active/inactive social accounts can now be seen for users by admins (Previously only shown to current user).
  • External auth ID field is now always available regardless of auth option set.

- Moved preference views to more general "my-account" area.
- Started new layout for my-account with sidebar.
- Added MFA to prefeences view (to be moved).
Text currently hard-coded, needs finalising and extracting.
Updated old user management routes to only be accessible with permission
to manage users, so also removed old content controls checking for that
permission.
Since management of API tokens can be accessed via two routes, this adds
tracking and handling to reutrn the user to the correct place.
- Updated existing tests now affected by my-account changes.
- Updated some existing tests to more accuractly check the scenario.
- Updated some code styling in SocialController.
- Fixed redirects for social account flows to fit my-account.
- Added test for social account attaching.
- Added test for api token redirect handling.
@ssddanbrown ssddanbrown merged commit 995b7d6 into development Oct 19, 2023
@ssddanbrown ssddanbrown deleted the user_account branch October 19, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.