Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

LawssssCat
Copy link
Contributor

Reference Issues: #4394

ssddanbrown added a commit that referenced this pull request Oct 6, 2023
Restructured tri-layout grid system, so the sidebars are contained in
their own child grid system, mimicking the parent grid, so we can treat
them as part of the same parent scroll container at smaller screen
sizes for consistent scroll/sticky behavior.

Tested on Firefox, Chromium, Gnome Web and Safari (MacOS).

For #4394
Changes made during review of #4562
@ssddanbrown ssddanbrown merged commit 588ed78 into BookStackApp:development Oct 6, 2023
@ssddanbrown
Copy link
Member

Thanks @LawssssCat, Now merged.
I followed this up with some more substantial layout structure changes in 0310677 to achieve a structure where the two sidebars can be treated as one, at this screen-size, for scrolling and sticky behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.