refactor: extract duplicated elem_types_to_hash logic#414
Open
sashass1315 wants to merge 1 commit intoBitVM:mainBitVM/BitVM:mainfrom
sashass1315:refactor/extract-elem-types-helpersashass1315/BitVM:refactor/extract-elem-types-helperCopy head branch name to clipboard
Open
refactor: extract duplicated elem_types_to_hash logic#414sashass1315 wants to merge 1 commit intoBitVM:mainBitVM/BitVM:mainfrom sashass1315:refactor/extract-elem-types-helpersashass1315/BitVM:refactor/extract-elem-types-helperCopy head branch name to clipboard
elem_types_to_hash logic#414sashass1315 wants to merge 1 commit intoBitVM:mainBitVM/BitVM:mainfrom
sashass1315:refactor/extract-elem-types-helpersashass1315/BitVM:refactor/extract-elem-types-helperCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic for building elem_types_to_hash (reversed parameter element types + result element type) was duplicated in two loops within partial_scripts_from_segments. Extracted into get_elem_types_to_hash helper function for clarity and maintainability.