Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: correct compact verifier comment and rename helper to leave bytes#391

Open
Fibonacci747 wants to merge 1 commit intoBitVM:mainBitVM/BitVM:mainfrom
Fibonacci747:fix/winternitz-compact-comment-and-bytes-namingFibonacci747/BitVM:fix/winternitz-compact-comment-and-bytes-namingCopy head branch name to clipboard
Open

fix: correct compact verifier comment and rename helper to leave bytes#391
Fibonacci747 wants to merge 1 commit intoBitVM:mainBitVM/BitVM:mainfrom
Fibonacci747:fix/winternitz-compact-comment-and-bytes-namingFibonacci747/BitVM:fix/winternitz-compact-comment-and-bytes-namingCopy head branch name to clipboard

Conversation

@Fibonacci747
Copy link
Copy Markdown

@Fibonacci747 Fibonacci747 commented Sep 15, 2025

  • Correct the comment for WINTERNITZ_MESSAGE_COMPACT_VERIFIER to say it returns the message in digits, matching its use of VoidConverter.
  • Rename generate_winternitz_checksig_leave_hash to generate_winternitz_checksig_leave_bytes to accurately describe that it leaves message bytes after verification.

These changes remove ambiguity between digits vs bytes and prevent confusion in future maintenance and usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Fibonacci747
Morty Proxy This is a proxified and sanitized view of the page, visit original site.