Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@hsadia538
Copy link

Part of Sweave2rmd project.

  • Create a vignette in R markdown which replaces the sweave vignette.
  • Fix Spellings

Attached are the HTML vignette and Sweave for comparison here.
ExtendingGenomicRanges Rmd File
ExtendingGenomicRanges Rnw File

@hsadia538
Copy link
Author

@jwokaty please take a look.
I was unsure of the hyperlinks and whether to add them or not e.g the title links to the package website in the PDF.

Copy link

@mcarlsn mcarlsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great conversation, I just left a few small edits. Thank you!

vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
getSlots("GNCList")["granges"]
```

The *MutableRanges* package in svn provides other, untested examples.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MutableRanges is italicized as well as a hyperlink in the original vignette so we can change this to MutableRanges (Although as a note to @jwokaty it looks like this link goes to a removed package).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpages Maybe this sentence should be removed since MutableRanges no longer exists?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please, thanks!

vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
vignettes/ExtendingGenomicRanges.Rmd Outdated Show resolved Hide resolved
@hsadia538
Copy link
Author

I have updated and pushed. the changes

@hsadia538
Copy link
Author

Hi
@jwokaty I see this PR is still open. Do you want me to close it?

@jwokaty jwokaty changed the title sweave2rmd: Convert ExtendingGenomicRanges.Rnw to .Rmd Convert ExtendingGenomicRanges.Rnw to .Rmd Jun 22, 2023
@jwokaty jwokaty requested a review from hpages June 22, 2023 16:47
@hpages
Copy link
Contributor

hpages commented Jan 19, 2024

@jwokaty What should we do with this PR?

@jwokaty
Copy link
Contributor

jwokaty commented Feb 1, 2024

@hpages Can you review and merge it if it looks good?

@hpages
Copy link
Contributor

hpages commented Feb 1, 2024

Please remove this line. The MutableRanges package is an abandonned project that never made it to Bioconductor. Thanks!

@hpages
Copy link
Contributor

hpages commented Mar 25, 2024

@hsadia538 Are you going to be able to make that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: PR Maintainer Review

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.