Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

NeuroML2 improvements #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: master
Choose a base branch
Loading
from
Open

NeuroML2 improvements #396

wants to merge 19 commits into from

Conversation

dilawar
Copy link
Contributor

@dilawar dilawar commented Mar 10, 2020 •
edited
Loading

This PR tracks improvements in NML2 support.

  • Supports Ca2+ dependant K channel.
  • Compare results with neuron simulator. Requires LEMS support.

Dilawar Singh added 9 commits March 10, 2020 15:20
saving data to npy format in streamer is now bug free. Added three te…
695d75b 
…sts: 2 python and 1 at cpp level.
boost::filesystem is no longer used even when boost is used.
182b705
Default tick for Streamer is 10s.
f25469a
Able to run nml2 example with python3 (BhallaLab/moose#253).
a10abc9
Able to run nml2 example with python3 (BhallaLab/moose#253).
6fce93b
moose.server uses the standard logger and does not set global logging to
d1b0662 
DEBUG mode.
Got reader.py from https://raw.githubusercontent.com/pgleeson/moose-c…
fd77d8e 
…ore/9834e98744610d9a920d1b63abfe128794abf16f/python/moose/neuroml2/reader.py
Pulled changes from pgleeson@29e089a
2143a04
Merge branch 'neuroml2' of github.com:dilawar/moose-core into neuroml2
ee7eaa1 
Changes were pulled in from pgleeson@29e089a
@dilawar dilawar self-assigned this Mar 10, 2020
- If nml user has set id of the gate to be 'x', 'y' or 'z' then load …
8a0bd8e 
…the dynamics into HHChannels's gateX, gateY, or gateZ dyamics.

- removed temp changes made to CaConcBase. It is not needed.
This was referenced Mar 12, 2020
Open
Open
@dilawar
Copy link
Contributor Author

dilawar commented Mar 19, 2020

@upibhalla This is still incomplete but can be merged for further testing and improvement.

@dilawar dilawar requested a review from upibhalla March 19, 2020 13:21
upibhalla
upibhalla approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@upibhalla upibhalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@dilawar dilawar marked this pull request as draft April 9, 2020 08:03
@dilawar dilawar marked this pull request as ready for review April 18, 2020 05:44
@dilawar dilawar closed this Jun 15, 2021
@dilawar dilawar deleted the neuroml2 branch October 28, 2021 11:19
@dilawar dilawar restored the neuroml2 branch October 28, 2021 11:19
@dilawar dilawar reopened this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upibhalla upibhalla upibhalla approved these changes

Assignees

@dilawar dilawar

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilawar @upibhalla
Morty Proxy This is a proxified and sanitized view of the page, visit original site.