Fix test flakes #65
Merged
Fix test flakes #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not order-guaranteed, and we should not assume an order. Instead, we can match on the name, as all clients should.
samandmoore
approved these changes
Feb 4, 2025
Member
samandmoore
left a comment
There was a problem hiding this comment.
domainlgtm platformlgtm
We've had to fix a few others like this. Good find.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the order of 'control' and 'treatment' in the returned list is not guaranteed. While we could enforce an order, clients should not assume an order. This updates the tests to match on split name when checking weights.
/no-platform