Updating MSAL to send client info = 2 on client credential flow #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
reviewed
Oct 14, 2025
src/client/Microsoft.Identity.Client/Internal/Requests/ClientCredentialRequest.cs
Show resolved
Hide resolved
added 2 commits
October 14, 2025 21:36
added test
bgavrilMS
reviewed
Oct 15, 2025
| /// <summary> | ||
| /// Represents the xms_acb claim in AuthN Tokens acquired from ESTS | ||
| /// </summary> | ||
| public List<string> AcbAuthN { get; set; } |
There was a problem hiding this comment.
Why not use AdditionalResponseParameters instead?
There was a problem hiding this comment.
Note that AdditionalResponseParamters is already exposed in Microsoft.idetity.Abstractions (but not in Id.Web)
There was a problem hiding this comment.
Yeah, I can add it there
bgavrilMS
reviewed
Oct 15, 2025
src/client/Microsoft.Identity.Client/Cache/Items/MsalAccessTokenCacheItem.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Added:
[OAuth2Parameter.ClientInfo]= "2" to the body parameters in theClientCredentialRequestThis ensures that client credential requests now include the client info parameter with a value of "2".
This tells ESTS to include xms_acb in the token response
Changes proposed in this request
Testing
Performance impact
Documentation