Improvements in Configuration Checks #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VM name, and subscription ID
…e disk query to include tier information. Refactor network checks report format to use 'check' instead of 'table'.
…e account and IP address detection
…G VM retrieval logic
…check output formatting
… and improve extraction of file share names.
… matching for Azure file endpoints.
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances SAP HANA configuration checks and storage data collection with improved NFS/AFS/ANF detection, more precise sysctl parameter validation for different storage types, and better formatting of LVM outputs.
Key changes include:
- Enhanced NFS mount detection and storage-type-specific ANF/AFS metadata collection
- Refactored sysctl checks to differentiate between premium storage and ANF storage requirements
- Added networking configuration checks and data collection
- Improved LVM size formatting using GiB/TiB units
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/module_utils/collector_test.py | Comprehensive test suite for collector module functionality |
| src/templates/config_checks_report.html | Enhanced report rendering with empty data handling and check sorting |
| src/roles/configuration_checks/tasks/main.yml | Added subscription ID context variable |
| src/roles/configuration_checks/tasks/files/virtual_machine.yml | Reorganized check IDs and improved PPG VM listing |
| src/roles/configuration_checks/tasks/files/network.yml | New networking configuration checks |
| src/roles/configuration_checks/tasks/files/hana.yml | Storage-type-specific sysctl parameter validation |
| src/roles/configuration_checks/tasks/disks.yml | Enhanced NFS detection and storage metadata collection |
| src/playbook_00_configuration_checks.yml | Added networking check integration |
| src/module_utils/filesystem_collector.py | Improved LVM size formatting with proper units |
… applicability in VM checks
…ion for consistency
…d secondary IP addresses
686b826
into
Azure:development-oct-2025
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to SAP HANA configuration checks and storage data collection, with a focus on enhanced NFS/AFS/ANF detection and reporting, as well as more precise sysctl parameter validation for different storage types. It also improves the formatting of LVM size outputs and expands the scope of configuration checks to include networking.
Storage & Filesystem Data Collection:
filesystem_collector.pyto useGiBandTiBunits, making outputs more readable and standardized. [1] [2]SAP HANA Configuration Checks:
premium_storageandanf), with updated expected values and references for each scenario. Added new checks fornet.core.rmem_max,net.core.wmem_max,net.ipv4.tcp_rmem, andnet.ipv4.tcp_wmemtailored to storage type. [1] [2] [3] [4] [5]Playbook Enhancements:
These changes improve the accuracy and relevance of configuration validation and storage metadata collection for SAP HANA workloads on Azure, supporting both operational and compliance requirements.