Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

jorgerangel-msft
Copy link
Member

@jorgerangel-msft jorgerangel-msft commented Oct 13, 2025

The Azure.AI.Inference library was generated and checked into main with a spec commit sha referencing a branch / fork. This PR removes the tsp-location.yaml file to disable generation for this library, and moves the generated code out of the Generated folder.

@jorgerangel-msft jorgerangel-msft force-pushed the remove-generatedcode-ai-inference branch from 0bdd49c to 5ca7773 Compare October 13, 2025 21:41
@jorgerangel-msft jorgerangel-msft changed the title [wip] move out generated code Disable generation of Azure.AI.Inference Oct 13, 2025
@jorgerangel-msft
Copy link
Member Author

@trangevi - please let us know if you have any objections to this change.

@jorgerangel-msft jorgerangel-msft marked this pull request as ready for review October 13, 2025 21:47
@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 21:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables automatic generation for the Azure.AI.Inference library by removing its tsp-location.yaml configuration file and updating file references to reflect the move from generated to manually maintained code.

  • Removes the tsp-location.yaml file that contained the specification location and commit reference
  • Updates XML documentation file paths from Generated folder to local Docs folder
  • Adds IncludeGeneratorSharedCode property to the project file

Reviewed Changes

Copilot reviewed 3 out of 119 changed files in this pull request and generated no comments.

File Description
sdk/ai/Azure.AI.Inference/tsp-location.yaml Removes entire file to disable generation
sdk/ai/Azure.AI.Inference/src/Customized/EmbeddingsClient.cs Updates XML documentation paths from Generated to local folder
sdk/ai/Azure.AI.Inference/src/Azure.AI.Inference.csproj Adds IncludeGeneratorSharedCode property and BOM marker

Copy link

github-actions bot commented Oct 13, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.AI.Inference

@JoshLove-msft
Copy link
Member

Can we run the migration script?

doc/GeneratorMigration/Library_Inventory.md Outdated Show resolved Hide resolved
@jorgerangel-msft jorgerangel-msft merged commit 4278b11 into Azure:main Oct 14, 2025
17 checks passed
@jorgerangel-msft jorgerangel-msft deleted the remove-generatedcode-ai-inference branch October 14, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.