Rename body parameter in non-resource method to "content". #53169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to rename body parameters in non-resource methods from generic names to "content" for better API consistency. The change ensures that body parameters in non-resource methods use a standardized naming convention while maintaining the existing "patch" naming for resource update methods.
- Introduces a caching mechanism for non-resource method providers to enable parameter renaming
- Adds logic to identify and rename body parameters in non-resource methods to "content"
- Extends the management input library to track models used as body parameters in non-resource methods
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NameVisitor.cs | Added logic to rename body parameters to "content" for non-resource methods and "patch" for resource methods |
| NonResourceMethodProviderCache.cs | New utility class providing thread-safe caching for non-resource method providers |
| MockableResourceProvider.cs | Updated to cache non-resource method providers during creation |
| ExtensionProvider.cs | Extended to cache redirect methods when their target methods are non-resource methods |
| ManagementInputLibrary.cs | Added functionality to identify models used as body parameters in non-resource methods |
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/NonResourceMethodProviderCache.cs
Outdated
Show resolved
Hide resolved
...rp-mgmt/generator/Azure.Generator.Management/src/Utilities/NonResourceMethodProviderCache.cs
Outdated
Show resolved
Hide resolved
...t-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableResourceProvider.cs
Outdated
Show resolved
Hide resolved
live1206
reviewed
Oct 13, 2025
...nt-csharp-mgmt/generator/Azure.Generator.Management/src/Utilities/MethodProviderExtension.cs
Outdated
Show resolved
Hide resolved
...s/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/ManagementInputLibrary.cs
Outdated
Show resolved
Hide resolved
...t-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableResourceProvider.cs
Show resolved
Hide resolved
...ges/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Visitors/NameVisitor.cs
Outdated
Show resolved
Hide resolved
live1206
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.