-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[Monitor] Query Metrics #53158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitor] Query Metrics #53158
Conversation
Note: Compliance failures are expected due to use of links that currently 404 but will be populated when the package is first published. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the new Azure.Monitor.Query.Metrics package, which splits the existing Azure.Monitor.Query functionality into discrete packages for Logs and Metrics. The new package provides a dedicated MetricsClient for querying Azure Monitor metrics across multiple resources in a single request.
Key changes:
- Creation of a new standalone Azure.Monitor.Query.Metrics package with its own MetricsClient
- Implementation of batch metrics querying functionality using QueryResources methods
- Addition of comprehensive test infrastructure and sample code
Reviewed Changes
Copilot reviewed 28 out of 66 changed files in this pull request and generated 7 comments.
File | Description |
---|---|
sdk/monitor/test-resources.bicep | Added new output variables for metrics testing including TENANT_ID and workspace keys |
sdk/monitor/Azure.Monitor.Query.Metrics/ | Complete new package structure including source code, tests, configuration files, and documentation |
Files not reviewed (1)
- sdk/monitor/Azure.Monitor.Query.Metrics/package-lock.json: Language not supported
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
f723fbb
to
f79ad09
Compare
The focus of these changes is the initial creation of the Azure.Monitor.Query.Metrics package, which splits the existing Azure.Monitor.Query functionality into discrete packages for Logs and Metrics.
b68dcee
to
d9bafb3
Compare
/check-enforcer override |
Summary
The focus of these changes is the initial creation of the Azure.Monitor.Query.Metrics package, which splits the existing Azure.Monitor.Query functionality into discrete packages for Logs and Metrics.