Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Oct 10, 2025

Summary

The focus of these changes is the initial creation of the Azure.Monitor.Query.Metrics package, which splits the existing Azure.Monitor.Query functionality into discrete packages for Logs and Metrics.

@jsquire jsquire requested review from scottaddie and srnagar October 10, 2025 21:43
@jsquire jsquire self-assigned this Oct 10, 2025
@jsquire jsquire requested a review from a team as a code owner October 10, 2025 21:43
@jsquire jsquire added the Client This issue is related to a non-management package label Oct 10, 2025
@jsquire
Copy link
Member Author

jsquire commented Oct 10, 2025

Note: Compliance failures are expected due to use of links that currently 404 but will be populated when the package is first published.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the new Azure.Monitor.Query.Metrics package, which splits the existing Azure.Monitor.Query functionality into discrete packages for Logs and Metrics. The new package provides a dedicated MetricsClient for querying Azure Monitor metrics across multiple resources in a single request.

Key changes:

  • Creation of a new standalone Azure.Monitor.Query.Metrics package with its own MetricsClient
  • Implementation of batch metrics querying functionality using QueryResources methods
  • Addition of comprehensive test infrastructure and sample code

Reviewed Changes

Copilot reviewed 28 out of 66 changed files in this pull request and generated 7 comments.

File Description
sdk/monitor/test-resources.bicep Added new output variables for metrics testing including TENANT_ID and workspace keys
sdk/monitor/Azure.Monitor.Query.Metrics/ Complete new package structure including source code, tests, configuration files, and documentation
Files not reviewed (1)
  • sdk/monitor/Azure.Monitor.Query.Metrics/package-lock.json: Language not supported

Copy link

github-actions bot commented Oct 11, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Azure.Monitor.Query.Metrics

@jsquire jsquire force-pushed the monitor/query-metrics branch from f723fbb to f79ad09 Compare October 14, 2025 18:51
sdk/monitor/Azure.Monitor.Query.Metrics/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/monitor/Azure.Monitor.Query.Metrics/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/monitor/Azure.Monitor.Query.Metrics/MigrationGuide.md Outdated Show resolved Hide resolved
sdk/monitor/Azure.Monitor.Query.Metrics/MigrationGuide.md Outdated Show resolved Hide resolved
The focus of these changes is the initial creation
of the Azure.Monitor.Query.Metrics package, which
splits the existing Azure.Monitor.Query functionality
into discrete packages for Logs and Metrics.
@jsquire jsquire force-pushed the monitor/query-metrics branch from b68dcee to d9bafb3 Compare October 14, 2025 23:34
@jsquire
Copy link
Member Author

jsquire commented Oct 14, 2025

/check-enforcer override

@jsquire jsquire merged commit fc5e85c into Azure:main Oct 15, 2025
15 of 17 checks passed
@jsquire jsquire deleted the monitor/query-metrics branch October 15, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue is related to a non-management package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.