Fix scale monitor descriptor function id #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
Hello @jainharsh98, Could you please take a look to this PR because as mentionned the target scaler does not work at all for now. Regards. |
|
Hello @jainharsh98, Any feedback for this simple fix? It prevents us to switch to target scaler, we are blocked for nearly 1 year. Thank you in advance. Best regards |
jainharsh98
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: jainharsh98 <jainh@microsoft.com>
jainharsh98
added a commit
that referenced
this pull request
Jul 30, 2024
* Changing all references to net8.0 and build errors * Fixing end to end tests for confluent * Changes to make Lang E22E tests succeed * Install .net8 sdk in the build pipeline * removing confluent sdk dependency on e2e tests * Upgrading confluent package to 2.4.0(#504) * Fix scale monitor descriptor function id (#451) Co-authored-by: jainharsh98 <jainh@microsoft.com> * SslKeyPassword resolution as secret setting for output binding (#464) Co-authored-by: Gregory van de Wiele <Gregory.vandeWiele@eneco.com> Co-authored-by: jainharsh98 <jainh@microsoft.com> * Added OAuthBearer authentication mode (#437) Co-authored-by: Hakan Altinbasak <hakan.altinbasak@avanade.com> Co-authored-by: jainharsh98 <jainh@microsoft.com> * Fixing Msg commit for Cancellation Scenarios (#505) * Commiting msg in single mode if cancellation is not requested. * Removing stray space character * Removing checks for specific and generic records to allow for other data types for out of proc (#506) * Fix for schema registry and UTs (#507) * Updating extension version to 4.0.0 * Resolving Oauthbearer Authentication Attributes from Settings for Output Binding (#511) * Resolving secure settings from settings for oauthbearer authentication * Adding Unit Test cases for oauthbearer settings --------- Co-authored-by: Vivek Jilla <vijilla@microsoft.com> Co-authored-by: Vivek Jilla <vivekjilla7@gmail.com> Co-authored-by: Pierre Sk <17861564+pierre-sk@users.noreply.github.com> Co-authored-by: gvdwiele <22445+gvdwiele@users.noreply.github.com> Co-authored-by: Gregory van de Wiele <Gregory.vandeWiele@eneco.com> Co-authored-by: Hakan <hakan.altinbasak@gmail.com> Co-authored-by: Hakan Altinbasak <hakan.altinbasak@avanade.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone,
The KafkaTargetScaler is using the obsolete ScaleMonitorDescriptor constructor without the functionId parameter.
When target scaling is enabled (by default) the ScaleManager compares the FunctionId to evaluate if a
ScaleMonitoris used in case aTargetScaleralready exists. But for the same function, the FunctionId of the TargetScaler and ScaleMonitor are not equal.Both
ScaleMonitorandTargetScalerare retrieved for sampling. It leads to a bad behavior as the ScaleManager doesn't use theTargetScalerto override the vote result when there is anyScaleMonitorstatus.Example of a bad result on
/admin/host/scale/statusfunction runtime endpoint:{ "vote": 0, "targetWorkerCount": 4, "functionScaleStatuses": { "my.functions.myfirstfunction.runasync-kafkatrigger-topic.myconsumer": { "vote": 0 }, "my.functions.mysecondfunction.runasync-kafkatrigger-topic.myconsumer": { "vote": 0 } }, "functionTargetScalerResults": { "My.Functions.MyFirstFunction.RunAsync": { "targetWorkerCount": 4 }, "My.Functions.MySecondFunction.RunAsync": { "targetWorkerCount": 1 } } }