Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

krishna-kariya
Copy link
Contributor

@krishna-kariya krishna-kariya commented Nov 1, 2022

Distributed Tracing Feature for Kafka Trigger Functions:

We are adding the Distributed Tracing feature for Kafka Trigger Functions in this PR. Through this feature, developers should be able to track every trigger request executed using Application Insights or any other tracing tool. Developers should be able to leverage the benefits of having a distributed trace.
Note: Currently, this feature is supported for Dotnet In-Proc Azure Kafka Trigger Functions only.

@krishna-kariya krishna-kariya marked this pull request as ready for review November 21, 2022 10:07
@shrohilla
Copy link
Contributor

@krishna-kariya could you please update the description for understanding the scope of the PR

@shrohilla
Copy link
Contributor

@krishna-kariya
The scope of this PR is not very clear are we only supporting below cases :-

  1. When customer is only passing the trace ??
  2. We are not supporting the case when trace is not there ??
  3. We are not supporting the output binding ??

@krishna-kariya
Copy link
Contributor Author

@krishna-kariya The scope of this PR is not very clear are we only supporting below cases :-

  1. When customer is only passing the trace ??
  2. We are not supporting the case when trace is not there ??
  3. We are not supporting the output binding ??

@shrohilla , The scope is very well defined and only includes tracing support for triggers as mentioned in the description. We have covered for all the cases - when traceparent is present, or not.

@shrohilla
Copy link
Contributor

@krishna-kariya since the case is only for trigger and as mentioned we are not supporting the output binding. In-that case it doesn't make sense to build a new trace in my opinion.

cc @raorugan & @lpapudippu

@krishna-kariya The scope of this PR is not very clear are we only supporting below cases :-

  1. When customer is only passing the trace ??
  2. We are not supporting the case when trace is not there ??
  3. We are not supporting the output binding ??

@shrohilla , The scope is very well defined and only includes tracing support for triggers as mentioned in the description. We have covered for all the cases - when traceparent is present, or not.

@krishna-kariya
Copy link
Contributor Author

@shrohilla , I think we had decided that distributed tracing support for output binding will be added later.

@shrohilla
Copy link
Contributor

@krishna-kariya the point is if we are not supporting for output binding in that case creating a new trace doesn't make sense.
Your scope is just to display the trace in app insights for the events which are being triggered and contains the traceid.
Creating a new trace in this case doesn't make sense to me.

lpapudippu
lpapudippu previously approved these changes Dec 23, 2022
Copy link
Contributor

@jainharsh98 jainharsh98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.