-
Notifications
You must be signed in to change notification settings - Fork 83
Distributed Tracing for trigger #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
test/Microsoft.Azure.WebJobs.Extensions.Kafka.UnitTests/DiagnosticTest.cs
Outdated
Show resolved
Hide resolved
…e/azure-functions-kafka-extension into kkariya/distributed-tracing
@krishna-kariya could you please update the description for understanding the scope of the PR |
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/ActivityProvider.cs
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/ActivityProvider.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/ActivityProvider.cs
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/ActivityProvider.cs
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/ActivityTags.cs
Show resolved
Hide resolved
src/Microsoft.Azure.WebJobs.Extensions.Kafka/Diagnostics/BatchEventActivityProvider.cs
Outdated
Show resolved
Hide resolved
@krishna-kariya
|
@shrohilla , The scope is very well defined and only includes tracing support for triggers as mentioned in the description. We have covered for all the cases - when traceparent is present, or not. |
@krishna-kariya since the case is only for trigger and as mentioned we are not supporting the output binding. In-that case it doesn't make sense to build a new trace in my opinion. cc @raorugan & @lpapudippu
|
@shrohilla , I think we had decided that distributed tracing support for output binding will be added later. |
@krishna-kariya the point is if we are not supporting for output binding in that case creating a new trace doesn't make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Distributed Tracing Feature for Kafka Trigger Functions:
We are adding the Distributed Tracing feature for Kafka Trigger Functions in this PR. Through this feature, developers should be able to track every trigger request executed using Application Insights or any other tracing tool. Developers should be able to leverage the benefits of having a distributed trace.
Note: Currently, this feature is supported for Dotnet In-Proc Azure Kafka Trigger Functions only.