Feat: support getting private endpoint info #78
Conversation
There was a problem hiding this comment.
Code Review Issues
1. Resource ID Validation Missing
File: internal/azureclient/client.go:347
Issue: No validation that the parsed resource ID is actually for a private endpoint.
Suggestion: Add validation to ensure the resource type is Microsoft.Network/privateEndpoints after parsing.
2. Context Propagation Issue
File: internal/components/network/handlers.go:297
Issue: Using context.Background() instead of propagating context from the handler.
Suggestion: Add context parameter to the handler function signature and propagate it through the call chain.
3. Minor Naming Inconsistency
File: internal/components/network/resourcehelpers/privateendpointhelpers.go:89
Suggestion: Consider renaming to getSubscriptionIDFromCluster for consistency with other getter functions.
4. Missing Timeout Configuration
Suggestion: Consider adding timeout configuration for Azure API calls to improve resilience.
Overall, this is a high-quality implementation with comprehensive test coverage. The issues identified are minor and don't affect core functionality.
This pull request introduces support for managing and retrieving information about private endpoints in Azure Kubernetes Service (AKS) clusters. The changes include updates to the Azure client, new helper functions for private endpoint handling, and new tools and tests for private endpoint functionality.
Azure client updates:
PrivateEndpointsClientto theSubscriptionClientsstruct and initialized it inGetOrCreateClientsForSubscription. [1] [2] [3]GetPrivateEndpointandGetPrivateEndpointByIDmethods to retrieve private endpoint details.Private endpoint functionality:
GetPrivateEndpointIDFromAKSinresourcehelpers/privateendpointhelpers.goto extract the private endpoint ID for AKS clusters.New tools and handlers:
GetPrivateEndpointInfoHandlerto retrieve private endpoint information via a new toolget_private_endpoint_info. [1] [2]Testing:
GetPrivateEndpointIDFromAKSandextractSubscriptionIDFromCluster.GetPrivateEndpointInfoHandlerto validate parameter handling and tool registration. [1] [2]