Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: add kubelogin to Dockerfile #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

feat: add kubelogin to Dockerfile #210

merged 1 commit into from
Sep 22, 2025

Conversation

mqasimsarfraz
Copy link
Member

This change adds kubelogin to the Dockerfile to allow clusters using Microsoft Entra authentication when using docker.

Testing Done

$ az aks get-credentials --resource-group qasim-rg --name qasim-entra-cluster --overwrite-existing
$ kubelogin convert-kubeconfig -l azurecli
$ docker run --rm -it --user 1000 -v $HOME/.azure:/home/mcp/.azure -v $HOME/.kube/config:/home/mcp/.kube/config --entrypoint=bash mcp/aks
cb5b4ba3b033:~$ kubectl get pods
No resources found in default namespace.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a653c33). Learn more about missing BASE report.
⚠️ Report is 133 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage        ?   37.95%           
=======================================
  Files           ?       65           
  Lines           ?     7843           
  Branches        ?        0           
=======================================
  Hits            ?     2977           
  Misses          ?     4708           
  Partials        ?      158

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mqasimsarfraz
feat: add kubelogin to Dockerfile
2f72584 
Signed-off-by: Qasim Sarfraz <qasimsarfraz@microsoft.com>
gossion
gossion approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@gossion gossion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks.

@gossion gossion added this pull request to the merge queue Sep 22, 2025
Merged via the queue into Azure:main with commit fece55b Sep 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gossion gossion gossion approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mqasimsarfraz @codecov-commenter @gossion
Morty Proxy This is a proxified and sanitized view of the page, visit original site.