Include hubble in additional tools #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
=======================================
Coverage ? 35.57%
=======================================
Files ? 61
Lines ? 6291
Branches ? 0
=======================================
Hits ? 2238
Misses ? 3958
Partials ? 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@feiskyer exposing this up from Azure/mcp-kubernetes#52 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the "hubble" Kubernetes tool as an optional component alongside existing tools like "helm" and "cilium". The changes update configuration, server registration logic, and tests to recognize and properly handle "hubble" as an optional tool.
Kubernetes tool support:
ParseFlagsmethod inconfig.goto include "hubble" as an available value for the--additional-toolsflag.hubblepackage import and implemented theregisterHubbleComponentmethod inserver.goto register the Hubble tool if enabled, and updated the logic that checks for enabled optional components. [1] [2] [3]Testing and tool categorization:
server_test.goto recognize "hubble" as a Kubernetes tool, and adjusted test cases to include "hubble" in expected tool counts and logging. [1] [2] [3] [4] [5]Related issue
Fixes #199