fix: stick footer to bottom of the page #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't replicate the issue, can you share a screenshot please? |
|
Sure! Current behavior on prod: Fix: |
AykutSarac
requested changes
Mar 31, 2025
|
Just removed all the changes from the footer except the 100% width which I found was necessary to cover all the space |
|
Container width is 100% by default if IIRC, it's a div. |
|
Based on testing, I found a few possible solutions:
Which one do you think is the most feasible? Third option looks a good tradeoff in my opinion. |
AykutSarac
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix footer positioning in converter tool pages
Previously, there was an empty space below the footer on the converter tool pages. I adjusted the layout to ensure that the pages take up the full available space, keeping the footer properly attached to the bottom.
Additionally, I noticed that these pages are not fully responsive. This could be improved in a future update.