Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed type for customerProfileId in request.#185

Closed
mdchaney wants to merge 3 commits intoAuthorizeNet:masterAuthorizeNet/sdk-ruby:masterfrom
mdchaney:mastermdchaney/sdk-ruby:masterCopy head branch name to clipboard
Closed

Fixed type for customerProfileId in request.#185
mdchaney wants to merge 3 commits intoAuthorizeNet:masterAuthorizeNet/sdk-ruby:masterfrom
mdchaney:mastermdchaney/sdk-ruby:masterCopy head branch name to clipboard

Conversation

@mdchaney
Copy link
Contributor

@mdchaney mdchaney commented Oct 7, 2020

In CreateCustomerProfileFromTransactionRequest the customerProfileId was
improperly specified as a NumericStringsType. This commit removes the
designation.

Note that in some places customerProfileId is specified as an Integer,
which is correct. There should probably be consistency applied.

Closes #180.

In CreateCustomerProfileFromTransactionRequest the customerProfileId was
improperly specified as a NumericStringsType.  This commit removes the
designation.

Note that in some places customerProfileId is specified as an Integer,
which is correct.  There should probably be consistency applied.

Closes AuthorizeNet#180.
@gnongsie
Copy link
Contributor

gnongsie commented Sep 2, 2024

We are relying on the API specification / XSD as the source of truth, and not the documentation, which may be a bit delayed in updating the details.
In any case, the docs are also in agreement that this field should be a numericString.
I am closing this PR as I do not see it as valid anymore.

@gnongsie gnongsie closed this Sep 2, 2024
@gnongsie
Copy link
Contributor

gnongsie commented Sep 2, 2024

Actually, correction. I must apologize here.
This change is valid and I will include it in my own pull request.

gnongsie added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Customer Profile from a Transaction customerProfileId undefined method `to_xml'

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.