feat(options): use the new winborder option to set floating window style
#2772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
This migrates to utilizing the
'winborder'option added in Neovim v0.11 for globally setting the default floating window border to"rounded". This helps create a unified user interface and a single location for users to change the general style of the editor.Todo
Known issues to be solved before this can be merged
winbordersetting (Neovim 0.11+) mason-org/mason.nvim#1899'winborder'folke/lazy.nvim#1951border = "none"onterminalsections folke/snacks.nvim#1643winborderoption folke/noice.nvim#1082winborderfrom 0.11 lewis6991/gitsigns.nvim#1241ℹ Additional Information
At the moment a ton of plugins have various levels of hard coded values for their window creation, so it's not a good idea to merge this quite yet. But we should keep an eye out on the ecosystem to see when is a good time to roll this out.