#94 Fixed issue where parsing font values with trailing commas causes…#96
Merged
eXpl0it3r merged 1 commit intoArthurHub:masterArthurHub/HTML-Renderer:masterfrom Dec 10, 2025
Merged
#94 Fixed issue where parsing font values with trailing commas causes…#96eXpl0it3r merged 1 commit intoArthurHub:masterArthurHub/HTML-Renderer:masterfrom
eXpl0it3r merged 1 commit intoArthurHub:masterArthurHub/HTML-Renderer:masterfrom
Conversation
…as causes an IndexOutOfRangeException.
eXpl0it3r
approved these changes
Dec 10, 2025
Collaborator
|
Thank you for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… an IndexOutOfRangeException.
When dealing with a property value with a trailing comma, the code would try to start from that comma, and increase the start index by one. This would cause the start index to go out of bounds since it was the last character in the string.
Also removed the check for start being greater than -1 since the start index is never decremented.
This fixes #94.