Update PDFsharp to 6.2.3#238
Open
eXpl0it3r wants to merge 1 commit intomasterArthurHub/HTML-Renderer:masterfrom
feature/update-pdfsharpArthurHub/HTML-Renderer:feature/update-pdfsharpCopy head branch name to clipboard
Open
Update PDFsharp to 6.2.3#238eXpl0it3r wants to merge 1 commit intomasterArthurHub/HTML-Renderer:masterfrom feature/update-pdfsharpArthurHub/HTML-Renderer:feature/update-pdfsharpCopy head branch name to clipboard
eXpl0it3r wants to merge 1 commit intomasterArthurHub/HTML-Renderer:masterfrom
feature/update-pdfsharpArthurHub/HTML-Renderer:feature/update-pdfsharpCopy head branch name to clipboard
Conversation
56cb783 to
7ba6f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #221
One of the major challenges with updating PDFsharp is, that it no longer depends on GDI for the font resolving, which is a good thing, as it makes HtmlRenderer.PdfSharp cross-platform, but also requires a custom cross-platform font resolver.
As I'm planning to use this for other projects that use PDFsharp, I've implemented FontResolver as a separate library, repo and NuGet.
Will need to check if #130 would be a good idea, when using HtmlRenderer.Gdi, so this custom resolver isn't needed in those cases.I'll move this to a separate change, so it's not further blocking.