comment out id in AoSIPPool ip_pool #3
Conversation
aos/resources.py
Outdated
| "tags": tags, | ||
| "display_name": name, | ||
| "id": name, | ||
| # "id": name, # generate to be compliant |
There was a problem hiding this comment.
A number of workflows work off the basis that the ID is the same as the name for convenience. Instead of removing this all together, I suggest using replace() to replace spaces with "-".
There was a problem hiding this comment.
Those scripts with name based should be modified anyway. If so, it would be straight forward to move to uuid instead another potential pitfalls in the future.
There was a problem hiding this comment.
It does not make sense to full on remove the functionality. Now if you want to introduce the option to set ID with default being to set as the name then I am fine with that too.
One of the core goals of this project is to make automation simpler for end users and having a simple human readable name for as many elements as possible helps us do that. It helps reduce workflows and lookup API calls.
aos/resources.py
Outdated
| "tags": tags, | ||
| "display_name": name, | ||
| "id": name, | ||
| # "id": name, # generate to be compliant |
There was a problem hiding this comment.
It does not make sense to full on remove the functionality. Now if you want to introduce the option to set ID with default being to set as the name then I am fine with that too.
One of the core goals of this project is to make automation simpler for end users and having a simple human readable name for as many elements as possible helps us do that. It helps reduce workflows and lookup API calls.
When the id is assigned from display_name which may have space in the middle, it breaks url /api/resources/ip-pools/{id}.