Fix for get_agent_by_id returning wrong class object #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
that1guy15
approved these changes
May 18, 2022
Contributor
that1guy15
left a comment
There was a problem hiding this comment.
Good catch, thank you!
that1guy15
pushed a commit
that referenced
this pull request
May 19, 2022
* add to the ignore directory * add the telemetry manager to the client * add telemetry support * import the AosTelemetryManager before use * remove the __pycache_ directory * remove the ip, username etc from sample script * address comments in PR * add types, clean up formatting with black * Fix for get_agent_by_id returning wrong class object (#22) * fixed the flake8 comments * add to the ignore directory * add the telemetry manager to the client * add telemetry support * import the AosTelemetryManager before use * remove the __pycache_ directory * remove the ip, username etc from sample script * address comments in PR * add types, clean up formatting with black * fixed the flake8 comments Co-authored-by: albertvaliev <105642351+albertvaliev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for get_agent_by_id trying and failing to return object with wrong class (System instead of SystemAgent)