build.py - Fix 'build.py libs' not actually initializing git submodules #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submodules directories always exist, so checking for their existance will always succeed, but initially they will be empty. Check instead for the existance of the .git file inside them. Also, run 'git submodule update' with '--recursive' flag as the submodules also have their own submodules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initial cloning and running "./build.py libs" the submodules directories always exist, so checking for their existence will always succeed, but initially they will be empty. This will cause the submodules to not be updated and the build to fail.
Check instead for the existence of the .git file inside them.
Also, run 'git submodule update' with '--recursive' flag as the submodules also have their own submodules. Not doing this will also end up with failing builds